Resolves: MTV-4551 | Add virtual machines to existing plan#2261
Resolves: MTV-4551 | Add virtual machines to existing plan#2261avivtur wants to merge 1 commit intokubev2v:mainfrom
Conversation
Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2261 +/- ##
===========================================
- Coverage 36.81% 14.56% -22.26%
===========================================
Files 158 1130 +972
Lines 2548 20288 +17740
Branches 599 4036 +3437
===========================================
+ Hits 938 2954 +2016
- Misses 1428 16670 +15242
- Partials 182 664 +482 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| // Read the name of a VM that is currently in the plan for exclusion checks | ||
| const plannedVmName = await planDetailsPage.virtualMachinesTab.getFirstVMName(); | ||
| expect(plannedVmName).toBeTruthy(); |
There was a problem hiding this comment.
Make sure all test logic are within step blocks
| }); | ||
|
|
||
| await test.step('4. Select a VM and verify confirm button becomes enabled', async () => { | ||
| const modal = await planDetailsPage.virtualMachinesTab.clickAddVirtualMachines(); |
There was a problem hiding this comment.
Test could possible be optimized by reducing number of times opening and closing of modal.
| await planDetailsPage.virtualMachinesTab.navigateToVirtualMachinesTab(); | ||
|
|
||
| // Wait for the status to reflect the archived state | ||
| await page.waitForTimeout(2000); |
There was a problem hiding this comment.
Is waitForTimeout avoidable here?
There was a problem hiding this comment.
Please consider reusing common/VirtualMachinesTable.ts or common/Table.ts page objects instead to avoid redefining common actions. getRowCount method could be moved to common/Table.ts since it's generic enough.
3 participants
📝 Links
https://issues.redhat.com/browse/MTV-4551
📝 Description
expose a dialog in the virtual machines tab to add virtual machines to the plan
🎥 Demo
📝 CC://